Micro-optimization: use if/else instead of Array#compact and Array#min (#19906)
				
					
				
			* Technically `if`/`else` is faster than using `[value1, value2].compact.min` to find the lesser of two values, one of which may be `nil`.
This commit is contained in:
		| @@ -139,7 +139,12 @@ class AccountStatusesCleanupPolicy < ApplicationRecord | ||||
|     # Filtering on `id` rather than `min_status_age` ago will treat | ||||
|     # non-snowflake statuses as older than they really are, but Mastodon | ||||
|     # has switched to snowflake IDs significantly over 2 years ago anyway. | ||||
|     max_id = [max_id, Mastodon::Snowflake.id_at(min_status_age.seconds.ago, with_random: false)].compact.min | ||||
|     snowflake_id = Mastodon::Snowflake.id_at(min_status_age.seconds.ago, with_random: false) | ||||
|  | ||||
|     if max_id.nil? || snowflake_id < max_id | ||||
|       max_id = snowflake_id | ||||
|     end | ||||
|  | ||||
|     Status.where(Status.arel_table[:id].lteq(max_id)) | ||||
|   end | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user