Assume children of visible IntersectionObserverArticle always change
This fixes multiple issues, while adding few computations
This commit is contained in:
		| @@ -5,8 +5,6 @@ import scheduleIdleTask from 'flavours/glitch/util/schedule_idle_task'; | ||||
| import getRectFromEntry from 'flavours/glitch/util/get_rect_from_entry'; | ||||
| import { is } from 'immutable'; | ||||
|  | ||||
| // Diff these props in the "rendered" state | ||||
| const updateOnPropsForRendered = ['id', 'index', 'listLength']; | ||||
| // Diff these props in the "unrendered" state | ||||
| const updateOnPropsForUnrendered = ['id', 'index', 'listLength', 'cachedHeight']; | ||||
|  | ||||
| @@ -34,9 +32,12 @@ export default class IntersectionObserverArticle extends React.Component { | ||||
|       // If we're going from rendered to unrendered (or vice versa) then update | ||||
|       return true; | ||||
|     } | ||||
|     // Otherwise, diff based on props | ||||
|     const propsToDiff = isUnrendered ? updateOnPropsForUnrendered : updateOnPropsForRendered; | ||||
|     return !propsToDiff.every(prop => is(nextProps[prop], this.props[prop])); | ||||
|     // If we are and remain hidden, diff based on props | ||||
|     if (isUnrendered) { | ||||
|       return !updateOnPropsForUnrendered.every(prop => is(nextProps[prop], this.props[prop])); | ||||
|     } | ||||
|     // Else, assume the children have changed | ||||
|     return true; | ||||
|   } | ||||
|  | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user