tarrien/Mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
d7eefab24daca767fa2b9f196c5eb884998a5b1f
Mastodon/app/models
History
Claire 526332c545 Fix account deletion sometimes failing because of optimistic locks (#16317) 
* Fix account deletion sometimes failing because of optimistic locks

In some rare occasions[1], deleting accounts would fail with a
`StaleObjectError` exception.

Indeed, account deletion manually sets the `AccountStat` values without
handling cases where the optimistic locking on `AccountStat` would fail.

To my knowledge, with the rewrite of account counters in #15913, the
`DeleteAccountService` is now the only place that changes the counters in
a way that is not atomic.

Since in this specific case, we do not care about the previous values of the
account counters, it appears we don't need locking at all for this table
anymore.

[1]: https://discourse.joinmastodon.org/t/account-cant-be-deleted/3602

* Bump MAX_SUPPORTED_VERSION in maintenance script
2021-06-02 17:41:25 +02:00
..
account_suggestions
Change auto-following admin-selected accounts, show in recommendations (#16078)
2021-04-24 17:01:43 +02:00
admin
Add management of delivery availability in Federation settings (#15771)
2021-05-05 23:39:02 +02:00
concerns
Fix account deletion sometimes failing because of optimistic locks (#16317)
2021-06-02 17:41:25 +02:00
form
Change auto-following admin-selected accounts, show in recommendations (#16078)
2021-04-24 17:01:43 +02:00
web
Add policy param to POST /api/v1/push/subscriptions (#16040)
2021-04-15 05:00:25 +02:00
account_alias.rb
Remove dependency on goldfinger gem (#14919)
2020-10-08 00:34:57 +02:00
account_conversation.rb
allow pagination by min_id and max_id (#14776)
2020-09-12 17:09:49 +02:00
account_deletion_request.rb
Change account suspensions to be reversible by default (#14726)
2020-09-15 14:37:58 +02:00
account_domain_block.rb
Fix crash when saving invalid domain name (#11528)
2019-08-08 23:04:19 +02:00
account_filter.rb
Fix admins being able to suspend their instance actor (#14567)
2020-12-15 17:23:58 +01:00
account_identity_proof.rb
Fix Keybase verification using wrong domain for remote accounts (#10547)
2019-04-10 20:28:43 +02:00
account_migration.rb
Fix race conditions on account migration creation (#15597)
2021-02-02 14:49:57 +01:00
account_moderation_note.rb
…
account_note.rb
Add user notes on accounts (#14148)
2020-06-30 19:19:50 +02:00
account_pin.rb
…
account_stat.rb
Fix account deletion sometimes failing because of optimistic locks (#16317)
2021-06-02 17:41:25 +02:00
account_suggestions.rb
Change auto-following admin-selected accounts, show in recommendations (#16078)
2021-04-24 17:01:43 +02:00
account_summary.rb
Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189)
2021-05-09 10:39:29 +02:00
account_warning_preset.rb
Add titles to warning presets in admin UI (#13252)
2020-03-12 17:57:59 +01:00
account_warning.rb
Add account sensitized (#14361)
2020-11-04 20:45:01 +01:00
account.rb
Remove PubSubHubbub-related columns from accounts table (#16170)
2021-05-07 19:32:58 +02:00
admin.rb
…
announcement_filter.rb
Add announcements (#12662)
2020-01-23 22:00:13 +01:00
announcement_mute.rb
Add announcements (#12662)
2020-01-23 22:00:13 +01:00
announcement_reaction.rb
Add announcements (#12662)
2020-01-23 22:00:13 +01:00
announcement.rb
Change order of announcements in admin page to sort them newest-first (#15091)
2020-11-04 21:15:22 +01:00
application_record.rb
Fix records not being indexed sometimes (#12024)
2019-10-01 01:19:11 +02:00
backup.rb
Add announcements (#12662)
2020-01-23 22:00:13 +01:00
block.rb
…
bookmark.rb
Add announcements (#12662)
2020-01-23 22:00:13 +01:00
canonical_email_block.rb
Add canonical e-mail blocks for suspended accounts (#16049)
2021-04-17 03:14:25 +02:00
context.rb
…
conversation_mute.rb
…
conversation.rb
Revert "Remove conversation URI (#11423)" (#11424)
2019-07-28 17:47:37 +02:00
custom_emoji_category.rb
Add batch actions and categories to admin UI for custom emojis (#11793)
2019-09-09 22:44:17 +02:00
custom_emoji_filter.rb
Various fixes and improvements (#12878)
2020-01-20 15:55:03 +01:00
custom_emoji.rb
Add separate cache directory for non-local uploads (#12821)
2020-04-26 23:29:08 +02:00
custom_filter.rb
Optimize map { ... }.compact calls (#15513)
2021-01-10 00:32:01 +01:00
device.rb
Add E2EE API (#13820)
2020-06-02 19:24:53 +02:00
domain_allow.rb
Fix performance on instances list in admin UI (#15282)
2020-12-14 09:06:34 +01:00
domain_block.rb
Add option to obfuscate domain name in public list of domain blocks (#15355)
2020-12-18 08:30:41 +01:00
email_domain_block.rb
Add option to include resolved DNS records when blacklisting e-mail domains in admin UI (#13254)
2020-03-12 22:35:20 +01:00
encrypted_message.rb
Change Redis#exists calls to Redis#exists? to avoid deprecation warning (#14191)
2020-07-01 19:05:21 +02:00
export.rb
Add import/export feature for bookmarks (#14956)
2020-11-19 17:48:13 +01:00
favourite.rb
Fix unnecessary queries when batch-removing statuses, 100x faster (#15387)
2020-12-22 17:13:55 +01:00
featured_tag.rb
Fix featured tags not finding the right tag on save (#11504)
2019-08-07 10:00:58 +02:00
feed.rb
allow pagination by min_id and max_id (#14776)
2020-09-12 17:09:49 +02:00
follow_recommendation_filter.rb
Add cold-start follow recommendations (#15945)
2021-04-12 12:37:14 +02:00
follow_recommendation_suppression.rb
Add cold-start follow recommendations (#15945)
2021-04-12 12:37:14 +02:00
follow_recommendation.rb
Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189)
2021-05-09 10:39:29 +02:00
follow_request.rb
Fix edge case where accepted follow cannot be processed because of follow limit (#16098)
2021-04-23 22:51:21 +02:00
follow.rb
Fix being able to import more than allowed number of follows (#15384)
2020-12-26 23:52:46 +01:00
home_feed.rb
Fix rubocop config and warnings (#15503)
2021-01-07 09:40:55 +01:00
identity.rb
Change identities id column to a bigint (#9371)
2018-11-27 13:56:25 +01:00
import.rb
Fix follow limit preventing re-following of a moved account (#14207)
2020-12-18 09:18:31 +01:00
instance_filter.rb
Add management of delivery availability in Federation settings (#15771)
2021-05-05 23:39:02 +02:00
instance.rb
Add management of delivery availability in Federation settings (#15771)
2021-05-05 23:39:02 +02:00
invite_filter.rb
Various fixes and improvements (#12878)
2020-01-20 15:55:03 +01:00
invite.rb
Change account suspensions to be reversible by default (#14726)
2020-09-15 14:37:58 +02:00
ip_block.rb
Add IP-based rules (#14963)
2020-10-12 16:33:49 +02:00
list_account.rb
Add abilityto add oneself to lists (#12271)
2019-11-04 13:02:01 +01:00
list_feed.rb
Fix rubocop config and warnings (#15503)
2021-01-07 09:40:55 +01:00
list.rb
Improve account deletion performances further (#15407)
2020-12-22 23:57:46 +01:00
marker.rb
Add timeline read markers API (#11762)
2019-09-06 13:55:51 +02:00
media_attachment.rb
Fix media processing getting stuck on too much stdin/stderr (#16136)
2021-05-05 19:44:01 +02:00
mention.rb
Improve support for aspects/circles (#8950)
2018-10-17 17:13:04 +02:00
message_franking.rb
Add E2EE API (#13820)
2020-06-02 19:24:53 +02:00
mute.rb
Add duration parameter to muting. (#13831)
2020-10-13 01:01:14 +02:00
notification.rb
Prepare Mastodon for Rails 6 (#15911)
2021-03-17 10:09:55 +01:00
one_time_key.rb
Add E2EE API (#13820)
2020-06-02 19:24:53 +02:00
poll_vote.rb
Add optimistic lock to avoid race conditions when handling votes (#10196)
2019-03-06 19:53:57 +01:00
poll.rb
Fix rubocop config and warnings (#15503)
2021-01-07 09:40:55 +01:00
preview_card.rb
Bump rubocop from 0.86.0 to 0.88.0 (#14412)
2020-09-01 03:04:00 +02:00
public_feed.rb
Fix rubocop config and warnings (#15503)
2021-01-07 09:40:55 +01:00
relationship_filter.rb
Fix followings list order | Issue #13538 (#13676)
2020-05-08 20:17:16 +02:00
relay.rb
Fix enable/disable relay failures (#13535)
2020-04-23 22:04:18 +02:00
remote_follow.rb
Remove dependency on goldfinger gem (#14919)
2020-10-08 00:34:57 +02:00
report_filter.rb
Various fixes and improvements (#12878)
2020-01-20 15:55:03 +01:00
report_note.rb
Fix scope latest of ReportNote (#9630)
2018-12-26 06:38:59 +01:00
report.rb
Update Mastodon to Rails 6.1 (#15910)
2021-03-24 10:44:31 +01:00
rule.rb
Add server rules (#15769)
2021-02-21 19:50:12 +01:00
scheduled_status.rb
Fix deleting a scheduled status immediately deleting media attachments (#9728)
2019-01-06 16:38:40 +01:00
search.rb
…
session_activation.rb
Add Ruby 3.0 support (#16046)
2021-05-06 14:22:54 +02:00
setting.rb
Use Rails' index_by where it makes sense (#15542)
2021-01-12 09:27:38 +01:00
site_upload.rb
Improvements to image upload validation and creation (#10431)
2019-04-01 07:30:46 +02:00
status_pin.rb
…
status_stat.rb
Reset status cache when status_stat or media_attachment updates (#9119)
2018-10-28 06:42:34 +01:00
status.rb
Fix nil error when removing status caused by race condition (#16099)
2021-04-24 13:35:39 +02:00
system_key.rb
Add E2EE API (#13820)
2020-06-02 19:24:53 +02:00
tag_feed.rb
Fix rubocop config and warnings (#15503)
2021-01-07 09:40:55 +01:00
tag_filter.rb
Change trending hashtags to be affected be reblogs (#16164)
2021-05-07 14:33:43 +02:00
tag.rb
Change trending hashtags to be affected be reblogs (#16164)
2021-05-07 14:33:43 +02:00
tombstone.rb
Record deleted(by mod) status to prevent re-appear (#10732)
2019-05-09 22:03:02 +02:00
trending_tags.rb
Change trending hashtags to be affected be reblogs (#16164)
2021-05-07 14:33:43 +02:00
unavailable_domain.rb
Fix performance on instances list in admin UI (#15282)
2020-12-14 09:06:34 +01:00
user_invite_request.rb
Add "why do you want to join" field to invite requests (#10524)
2019-04-09 23:06:30 +09:00
user.rb
Add Ruby 3.0 support (#16046)
2021-05-06 14:22:54 +02:00
web.rb
…
webauthn_credential.rb
Fix validates :sign_count of WebauthnCredential (#14806)
2020-09-16 20:16:46 +02:00