Commit Graph

188 Commits

Author SHA1 Message Date
cee4369cf5 Autofix Rubocop Lint/AmbiguousOperatorPrecedence (#25002) 2023-05-16 10:51:59 +02:00
2c2d924942 Fix RSpec/RepeatedExampleGroupDescription cop (#24850)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-05-12 12:25:32 +02:00
bf3ebeb42f Fix RSpec/SharedContext cop (#24847) 2023-05-12 09:25:43 +02:00
a610a02d4f Fix RSpec/ScatteredSetup cop (#24848) 2023-05-11 10:32:09 +02:00
8b31030fe4 Fix rubocop issues in glitch-soc-specific code 2023-05-08 19:28:43 +02:00
d77fbbed73 Merge commit 'f877aa9d70d0d600961989b8e97c0e0ce3ac1db6' into glitch-soc/merge-upstream
Conflicts:
- `.github/dependabot.yml`:
  Upstream made changes, but we had removed it.
  Discarded upstream changes.
- `.rubocop_todo.yml`:
  Upstream regenerated the file, we had some glitch-soc-specific ignores.
- `app/models/account_statuses_filter.rb`:
  Minor upstream code style change where glitch-soc had slightly different code
  due to handling of local-only posts.
  Updated to match upstream's code style.
- `app/models/status.rb`:
  Upstream moved ActiveRecord callback definitions, glitch-soc had an extra one.
  Moved the definitions as upstream did.
- `app/services/backup_service.rb`:
  Upstream rewrote a lot of the backup service, glitch-soc had changes because
  of exporting local-only posts.
  Took upstream changes and added back code to deal with local-only posts.
- `config/routes.rb`:
  Upstream split the file into different files, while glitch-soc had a few
  extra routes.
  Extra routes added to `config/routes/settings.rb`, `config/routes/api.rb`
  and `config/routes/admin.rb`
- `db/schema.rb`:
  Upstream has new migrations, while glitch-soc had an extra migration.
  Updated the expected serial number to match upstream's.
- `lib/mastodon/version.rb`:
  Upstream added support to set version tags from environment variables, while
  glitch-soc has an extra `+glitch` tag.
  Changed the code to support upstream's feature but prepending a `+glitch`.
- `spec/lib/activitypub/activity/create_spec.rb`:
  Minor code style change upstream, while glitch-soc has extra tests due to
  `directMessage` handling.
  Applied upstream's changes while keeping glitch-soc's extra tests.
- `spec/models/concerns/account_interactions_spec.rb`:
  Minor code style change upstream, while glitch-soc has extra tests.
  Applied upstream's changes while keeping glitch-soc's extra tests.
2023-05-08 19:28:21 +02:00
2d029dedd9 Merge commit '0ad2413b35287958f59073a5b63aecc659a64d98' into glitch-soc/merge-upstream
Conflicts:
- `app/javascript/styles/mastodon/forms.scss`:
  Conflict because we ran eslint autofix on upstream files.
- `config/initializers/content_security_policy.rb`:
  Code style changes but we have a different version.
  Kept our version.
- `streaming/index.js`:
  Upstream fixed a typo close to glitch-soc-only code.
  Applied upstream's changes.
2023-05-08 15:28:36 +02:00
9b59748679 Fix rubocop warnings (#2206) 2023-05-07 15:06:15 +02:00
0b249ebdb0 Extract StatusSafeReblogInsert concern from Status (#24821) 2023-05-04 14:06:20 +02:00
569b39256b Bump rubocop-rails 2.19.1 with update .rubocop_todo.yml (#24469) 2023-05-04 11:56:24 +02:00
e1ebcc007d Regenerate rubocop-todo (#24834) 2023-05-04 07:43:54 +02:00
ff3b7069cf Autofix Rubocop Style/ConcatArrayLiterals (#23755) 2023-05-04 05:57:40 +02:00
da3bd913ae Autofix Rubocop Style/HashSyntax (#23754) 2023-05-04 05:54:26 +02:00
d5a185d721 Autofix Rubocop Style/CaseLikeIf (#23756) 2023-05-04 05:51:18 +02:00
1fe04f740a Enable Rubocop Rails/FilePath (#23854) 2023-05-04 05:50:40 +02:00
c97b611b6b Fix RSpec/InferredSpecType cop (#24736) 2023-05-04 05:49:53 +02:00
710745e16b Fix RSpec/ContextWording cop (#24739) 2023-05-04 05:49:08 +02:00
cf18cc2891 Fix RSpec/MultipleSubjects cop (#24738) 2023-05-04 05:48:35 +02:00
2c6c398c60 Fix Performance/CollectionLiteralInLoop cop (#24819) 2023-05-04 05:33:55 +02:00
d9a958fcf7 Fix Performance/RedundantMerge cop (#24817) 2023-05-04 05:25:43 +02:00
3df665fd23 Fix Lint/ConstantDefinitionInBlock cop (#24763) 2023-05-03 10:32:30 +02:00
a0c9f2447e Fix Performance/MethodObjectAsBlock cop (#24798) 2023-05-03 10:30:54 +02:00
97385f27bd Fix Performance/RedundantEqualityComparisonBlock cop (#24799) 2023-05-03 10:30:10 +02:00
668a19a2f3 Fix Performance/DeletePrefix cop (#24796) 2023-05-02 21:07:45 +02:00
05e3abe9d9 Fix Lint/EmptyClass cop (#24795) 2023-05-02 21:06:51 +02:00
24491abf6d Fix Rails/DeprecatedActiveModelErrorsMethods cop (#24742) 2023-05-02 18:39:22 +02:00
b5c4b47746 Fix Rails/ActiveRecordCallbacksOrder cop (#24689) 2023-05-02 18:23:35 +02:00
38b2974a83 Extract AccountSearch concern from Account (#24716) 2023-05-02 18:21:36 +02:00
f1c1dd0118 Rename with_lock to with_redis_lock to avoid confusion with ActiveRecord's method (#24741) 2023-05-02 18:16:07 +02:00
570079f8ce Fix Performance/TimesMap cop (#24789) 2023-05-02 18:07:16 +02:00
bae694108a Fix Performance/Count cop (#24793) 2023-05-02 18:06:43 +02:00
5e060e1f44 Fix Performance/Sum cop (#24788) 2023-05-02 16:10:40 +02:00
88d33f361f Fix Lint/DuplicateBranch cop (#24766) 2023-05-02 12:57:11 +02:00
32a030dd74 Rewrite import feature (#21054) 2023-05-02 12:08:48 +02:00
c53fe9b753 Fix RSpec/BeforeAfterAll cop (#24737) 2023-05-01 04:16:08 +09:00
d902a707a3 Fix Rails/CompactBlank cop (#24690) 2023-04-30 14:07:21 +02:00
d00e45a7d3 Fix Rails/I18nLocaleAssignment cop (#24693) 2023-04-30 14:07:03 +02:00
af824db398 Fix Rails/InverseOf cop (#24732) 2023-04-30 14:06:53 +02:00
2e43461100 Fix Rails/Output cop (#24687) 2023-04-30 06:48:16 +02:00
5a2aa06a51 Fix Rails/Present cop (#24688) 2023-04-30 06:47:50 +02:00
bdc74086e6 Fix Rails/ContentTag cop (#24691) 2023-04-30 06:47:15 +02:00
6e226f5a32 Fix Rails/ActionOrder cop (#24692) 2023-04-30 06:46:39 +02:00
60ac9e8634 Fix Rails/SquishedSQLHeredocs cop (#24694) 2023-04-30 06:43:50 +02:00
8dcfb6e0ea Fix Rails/HttpPositionalArguments cop (#24699) 2023-04-30 06:43:28 +02:00
4cfe52635c Add pending spec for User.those_who_can (#24724) 2023-04-29 22:03:36 +02:00
12b935fadf Merge branch 'main' into glitch-soc/merge-upstream
Conflicts:
- `.github/dependabot.yml`:
  Updated upstream, removed in glitch-soc to disable noise.
  Kept removed.
- `CODE_OF_CONDUCT.md`:
  Upstream updated to a new version of the covenant, but I have not read it
  yet, so kept unchanged.
- `Gemfile.lock`:
  Not a real conflict, one upstream dependency updated textually too close to
  the glitch-soc only `hcaptcha` dependency.
  Applied upstream changes.
- `app/controllers/admin/base_controller.rb`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `app/controllers/application_controller.rb`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `app/controllers/disputes/base_controller.rb`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `app/controllers/relationships_controller.rb`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `app/controllers/statuses_cleanup_controller.rb`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `app/helpers/application_helper.rb`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `app/javascript/mastodon/features/compose/components/compose_form.jsx`:
  Upstream added a highlight animation for onboarding, while we changed the
  max character limit.
  Applied our local changes on top of upstream's new version.
- `app/views/layouts/application.html.haml`:
  Minor conflict due to glitch-soc's theming system.
  Applied upstream changes.
- `stylelint.config.js`:
  Upstream added ignore paths, glitch-soc had extra ignore paths.
  Added the same paths as upstream.
2023-04-29 10:44:56 +02:00
49fad26eca Drop EOL Ruby 2.7 (#24237) 2023-04-27 01:46:18 +02:00
5841f1af8c Autofix Rubocop RSpec/MatchArray (#24675) 2023-04-26 21:29:36 +02:00
a3393d0d07 Autofix Rubocop RSpec/MatchArray (#24050) 2023-04-26 20:21:54 +02:00
90beba57d8 Autofix Rubocop Rails/ResponseParsedBody (#24051) 2023-04-26 17:25:07 +02:00