Commit Graph

3909 Commits

Author SHA1 Message Date
0c7dc6c781 Merge remote-tracking branch 'tootsuite/master' into glitchsoc/master 2018-01-15 06:17:15 +00:00
74c1c9ec01 Allow attributedTo in a status to be an embedded object (#6238) 2018-01-15 06:51:46 +01:00
537d2939b1 Suppress CSRF token warnings (#6240)
CSRF token checking was enabled for API controllers in #6223,
producing "Can't verify CSRF token authenticity" log spam. This
disables logging of failed CSRF checks.

This also changes the protection strategy for
PushSubscriptionsController to use exceptions, making it consistent
with other controllers that use sessions.
2018-01-15 06:51:23 +01:00
2091ae92be Make columns-area unscrollable when modal opened (#6241)
* Add aria-autocomplete='list' in Textaria

ref: https://www.w3.org/TR/wai-aria-1.1/#aria-autocomplete

* Make detect empty string brefore assign upload description

* Change code elements in keyboard-shortcuts component to kbd

* Add validation for onMuteNotifications

* Make columns-area unscrollable when modal opend

* Make columns-area unscrollable when modal opened
2018-01-15 06:51:00 +01:00
ed867eca9d Move e-mail digest task to sidekiq, reduce workload, improve hint (#6252) 2018-01-15 04:34:28 +01:00
08e4c78e78 Fix column headers accessibility (#6199)
* Fix accessibility of column headers

As a screen reader user new to Mastodon, I encountered the following issues with the column headers as designed:
 * Jumping between them was difficult. FOr instance, passing my home timeline to reach notification settings was difficult to impossible, especially considering infinite scrolling.
 * There doesn't appear to be any means for triggering the control via the keyboard. the `titleClick` handler only responds to mouse clicks.
 * I didn't even realize there was a Settings toggle until I made this change.

Thanks for using ARIA in your designs. It's a huge help. But adding a `button` role doesn't add keyboard handling and other button behavior. Also, because the role was on the heading container, it obscured the controls within the container itself. This fix resolve that. It also exposes the headings as headings rather than buttons, enabling skipping columns by using screen readers' heading navigation commands.

Since I myself am blind, if this fix requires additional visual styling, I'd like help applying that so it can be merged. I'd consider it an essential accessibility fix for my and other blind users' existence on the platform. Thanks!

* Styling fixes

* Fixed overflow issue
2018-01-15 04:33:06 +01:00
8ee6ed358f Increase priority of favstar gold 2018-01-14 16:05:44 -08:00
1ee0e91fb6 Fixes to notification styling 2018-01-14 15:48:54 -08:00
b9f4896830 Fixes to drawer and CWs 2018-01-14 15:31:00 -08:00
cd6674606f Merge pull request #329 from KnzkDev/scss-refactor
SCSS Refactor
2018-01-14 17:48:02 -05:00
39f231f3da Merge pull request #328 from glitch-soc/feature/glitchy-elephant-friend
Add glitchy elephant friend
2018-01-14 17:40:27 -05:00
0fb3bd09e9 Oops this should have been a part of last commit 2018-01-14 14:21:41 -08:00
1fa03e026a Fixes onboarding modal (#318) 2018-01-14 14:13:24 -08:00
a5931e1f48 Fixed autocollapse detection 2018-01-14 13:29:51 -08:00
c2669f93d0 Fix eslint errors. #294. 2018-01-14 05:56:43 -06:00
756a9cd139 Run slightly less afoul of accessibility checks. #294.
This makes the clickable element an interactive element, but doesn't add
alt text and makes it not-obvious that you can click the elefriend.  On
one hand, this goes against good practice; on the other hand, it's not
*supposed* to be obvious that you can click the elefriend.
2018-01-14 05:07:08 -06:00
e64cc311dd Introduce a bit of luck into the elefriend selection. #294. 2018-01-14 04:46:21 -06:00
53cbc9933e Add wave background; blend elefriend in a bit more. #294. 2018-01-14 04:00:21 -06:00
cd1377de7f Bind click event to elefriend cycling. #294. 2018-01-14 03:35:25 -06:00
1dbb6b5e08 Set glitchy elephant friend variant in initial state. #294.
Also lay some groundwork needed to interactively change the
glitchfriend.

The codebase uses "elefriend" because it's shorter and didn't require me
to realign the actions in actions/compose.js.  Same idea, though.
2018-01-14 03:06:11 -06:00
1e0b707018 Add the shrinking glitchy elefriend. #294. 2018-01-13 21:27:39 -06:00
835eec8a4c Prototype out glitchy elephant friend. #294.
Glitched elephant friends kindly provided by @ncls7615.
2018-01-13 21:27:14 -06:00
f9b08e2142 Fix collapsed toot style 2018-01-14 11:13:55 +09:00
1ebe66b78c Fix un-fullwidth media style 2018-01-14 11:07:32 +09:00
be2bac05aa Fix media detailed style 2018-01-14 10:38:51 +09:00
b5476f6c75 Fix confirmation modal bug 2018-01-14 09:51:01 +09:00
bc0524834e Fix letterbox bug 2018-01-14 09:25:35 +09:00
6ecf81cacf Improve scss refactor 5 2018-01-14 09:17:38 +09:00
64425dbb77 Improve scss refactor 4 2018-01-14 09:12:10 +09:00
a16d885ac9 Improve scss refactor 3 2018-01-14 08:47:59 +09:00
5f35b39f6f Improve scss refactor 2 2018-01-14 07:48:18 +09:00
bb2ca23839 Improve scss refactor 1 2018-01-14 07:18:50 +09:00
a9be680807 Fix padded-blocks error 2018-01-14 04:12:41 +09:00
6a73c8c8a2 Initial scss refactor 2018-01-14 03:41:20 +09:00
3a0b47982d load public.js on vanilla#admin 2018-01-12 18:52:53 -08:00
9b9b7fa005 Load packs/public.js for glitch#admin 2018-01-12 18:51:52 -08:00
0210e59759 Merge remote-tracking branch 'remotes/origin/fix-column-headers-accessibility' 2018-01-12 20:10:58 -06:00
ee7217bc94 i18n: Update Polish translation
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
2018-01-12 23:08:51 +01:00
cf5789146b Fix dropdown text 2018-01-12 23:18:25 +09:00
9fa79bc317 Merge remote-tracking branch 'tootsuite/master' into glitchsoc/master 2018-01-12 02:17:15 +00:00
704053d221 Handle sessions that can't be translated (#6245)
* Handle sessions that can't be translated

This commit fixes #6165.

* Fix typo
2018-01-12 02:44:28 +01:00
395e64e858 Thank you, Officer Murphy 2018-01-10 12:10:43 -06:00
514db316f7 The flavour parameter is unused, so omit it (#317) 2018-01-10 12:09:42 -06:00
6fcb870d96 Allow for user object to be empty. Fixes #317.
If a flavour has only one skin, the skin selector will be omitted.  This
omits the user[setting_skin] field, and because that's the only
user[...] field on the page, the entire user object will not be present
in the request handler's params object.

This commit accounts for that scenario by avoiding params.require(:user)
and instead picking out what we need from the params hash.
2018-01-10 12:09:42 -06:00
095a00ef3d Merge pull request #316 from glitch-soc/fix-async
Fix glitch async chunks
2018-01-09 18:30:45 -06:00
35be02f21d Renamed glitch async chunks 2018-01-09 16:26:14 -08:00
622c8fdb75 Merge pull request #314 from chriswmartin/merge-vanilla-updates-2
Merge vanilla updates into glitch - round 2
2018-01-09 17:01:23 -06:00
991371af5f Merge remote-tracking branch 'origin/master' into merge-upstream
Conflicts:
	db/schema.rb
2018-01-09 14:16:45 -06:00
35b84985a8 Skip ActivityPub Announces of non-public objects (#6230)
* Skip ActivityPub Announces of non-public objects

* Skip OStatus reblogs of non-public statuses
2018-01-09 19:35:10 +01:00
d41f0b66cc Fix #6204: Use content warning for page title when present (#6231) 2018-01-09 19:34:58 +01:00