tarrien/Mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor handling of default params for muting to make code cleaner

Browse Source
This commit is contained in:
Surinna Curtis
2017-09-13 18:32:10 -05:00
parent 211f0a9513
commit f9d7b8a94f
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/concerns/account_interactions.rb
View File

@@ -74,7 +74,8 @@ module AccountInteractions
block_relationships.find_or_create_by!(target_account: other_account)
end
def mute!(other_account, notifications: true)
def mute!(other_account, notifications: nil)
notifications = true if notifications.nil?
mute = mute_relationships.create_with(hide_notifications: notifications).find_or_create_by!(target_account: other_account)
# When toggling a mute between hiding and allowing notifications, the mute will already exist, so the find_or_create_by! call will return the existing Mute without updating the hide_notifications attribute. Therefore, we check that hide_notifications? is what we want and set it if it isn't.
if mute.hide_notifications? != notifications