Add finer permission requirements for managing webhooks (#25463)

2023-06-22 14:52:25 +02:00
parent 8acbfc6ab1
commit e65e3a6d14
5 changed files with 30 additions and 3 deletions
--- a/app/policies/webhook_policy.rb
+++ b/app/policies/webhook_policy.rb
@ -14,7 +14,7 @@ class WebhookPolicy < ApplicationPolicy
  end

  def update?
-    role.can?(:manage_webhooks)
+    role.can?(:manage_webhooks) && record.required_permissions.all? { |permission| role.can?(permission) }
  end

  def enable?
@ -30,6 +30,6 @@ class WebhookPolicy < ApplicationPolicy
  end

  def destroy?
-    role.can?(:manage_webhooks)
+    role.can?(:manage_webhooks) && record.required_permissions.all? { |permission| role.can?(permission) }
  end
 end