tarrien/Mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some more Javascript linting issues and discrepancies with upstream (#2209)

Browse Source 
* Fix typo in flavours/glitch/features/video/index.js

* Fix various linting issues and discrepancies with upstream
This commit is contained in:
Claire
2023-05-07 21:43:25 +02:00
committed by GitHub
parent ed0a407888
commit de74acbe0c
39 changed files with 87 additions and 200 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/javascript/flavours/glitch/features/compose/components/dropdown_menu.jsx
View File

@ -1,7 +1,6 @@
// Package imports.
import PropTypes from 'prop-types';
import React from 'react';
import ImmutablePureComponent from 'react-immutable-pure-component';
import classNames from 'classnames';
// Components.
@ -9,7 +8,6 @@ import Icon from 'flavours/glitch/components/icon';
// Utils.
import { withPassive } from 'flavours/glitch/utils/dom_helpers';
import { assignHandlers } from 'flavours/glitch/utils/react_helpers';
// The component.
export default class ComposerOptionsDropdownContent extends React.PureComponent {
@ -78,7 +76,8 @@ export default class ComposerOptionsDropdownContent extends React.PureComponent
items,
} = this.props;
const { name } = this.props.items[i];
const { name } = items[i];
e.preventDefault(); // Prevents change in focus on click
if (closeOnChange) {
onClose();
@ -131,7 +130,7 @@ export default class ComposerOptionsDropdownContent extends React.PureComponent
if (element) {
element.focus();
this.handleChange(this.props.items[Number(element.getAttribute('data-index'))].name);
this.handleChange(items[Number(element.getAttribute('data-index'))].name);
e.preventDefault();
e.stopPropagation();
}
@ -169,6 +168,7 @@ export default class ComposerOptionsDropdownContent extends React.PureComponent
onClick={this.handleClick}
onKeyDown={this.handleKeyDown}
role='option'
aria-selected={active}
tabIndex={0}
key={name}
data-index={i}
@ -183,8 +183,6 @@ export default class ComposerOptionsDropdownContent extends React.PureComponent
render () {
const {
items,
onChange,
onClose,
style,
} = this.props;