Fix invalid votes from the API being accepted (#12601)

* Fix invalid votes from the API being accepted Fixes #12556 - Ensure `choice` is an integer instead of silently converting to 0 - Ensure `choice` corresponds to an actual choice of the poll * Please CodeClimate
2020-01-12 14:17:03 +01:00
parent 7da54001fe
commit d386d89179
3 changed files with 10 additions and 1 deletions
--- a/app/services/vote_service.rb
+++ b/app/services/vote_service.rb
@ -20,7 +20,7 @@ class VoteService < BaseService

        ApplicationRecord.transaction do
          @choices.each do |choice|
-            @votes << @poll.votes.create!(account: @account, choice: choice)
+            @votes << @poll.votes.create!(account: @account, choice: Integer(choice))
          end
        end
      else