Implement infinity home timeline (#1610)

* Implement infinity home timeline

* Fix test for infinite home timeline

* Fix infinity home timeline with min_id

* Fix infinite home timeline duplicated statuses

* Codeclimate for infinite home timeline

* Refactor code as reviewed

* Fix redis sufficient check

* Fix typo on variable name
This commit is contained in:
Jeong Arm
2022-04-13 00:52:14 +09:00
committed by GitHub
parent b9b9192432
commit d353bb5ee3
2 changed files with 51 additions and 4 deletions

View File

@@ -21,12 +21,17 @@ RSpec.describe HomeFeed, type: :model do
)
end
it 'gets statuses with ids in the range from redis' do
it 'gets statuses with ids in the range from redis with database' do
results = subject.get(3)
expect(results.map(&:id)).to eq [3, 2]
expect(results.map(&:id)).to eq [3, 2, 1]
expect(results.first.attributes.keys).to eq %w(id updated_at)
end
it 'with min_id present' do
results = subject.get(3, nil, nil, 0)
expect(results.map(&:id)).to eq [3, 2, 1]
end
end
context 'when feed is being generated' do
@@ -34,10 +39,15 @@ RSpec.describe HomeFeed, type: :model do
Redis.current.set("account:#{account.id}:regeneration", true)
end
it 'returns nothing' do
it 'returns from database' do
results = subject.get(3)
expect(results.map(&:id)).to eq []
expect(results.map(&:id)).to eq [10, 3, 2]
end
it 'with min_id present' do
results = subject.get(3, nil, nil, 0)
expect(results.map(&:id)).to eq [3, 2, 1]
end
end
end