Fix #2955 - Send HEAD request ahead of GET when fetching URL previews (#2972)

2017-05-10 23:30:07 +02:00
parent c3ef5d5414
commit a231f915a0
2 changed files with 6 additions and 1 deletions
--- a/app/services/fetch_link_card_service.rb
+++ b/app/services/fetch_link_card_service.rb
@ -11,8 +11,12 @@ class FetchLinkCardService < BaseService

    return if url.nil?

-    url = Addressable::URI.parse(url).normalize.to_s
+    url  = Addressable::URI.parse(url).normalize.to_s
    card = PreviewCard.where(status: status).first_or_initialize(status: status, url: url)
+    res  = http_client.head(url)
+
+    return if res.code != 200 || res.mime_type != 'text/html'
+
    attempt_opengraph(card, url) unless attempt_oembed(card, url)
  end