Fix Lint/DuplicateBranch cop (#24766)

2023-05-02 06:57:11 -04:00
parent f50105779b
commit 88d33f361f
6 changed files with 56 additions and 31 deletions
--- a/app/validators/email_mx_validator.rb
+++ b/app/validators/email_mx_validator.rb
@ -8,9 +8,7 @@ class EmailMxValidator < ActiveModel::Validator

    domain = get_domain(user.email)

-    if domain.blank?
-      user.errors.add(:email, :invalid)
-    elsif domain.include?('..')
+    if domain.blank? || domain.include?('..')
      user.errors.add(:email, :invalid)
    elsif !on_allowlist?(domain)
      resolved_ips, resolved_domains = resolve_mx(domain)