Remove intermediary arrays when creating hash maps from results (#9291)

2018-11-16 15:02:18 +01:00
parent 367ad21995
commit 8069fd636b
11 changed files with 20 additions and 20 deletions
--- a/app/lib/entity_cache.rb
+++ b/app/lib/entity_cache.rb
@ -21,7 +21,7 @@ class EntityCache
    end

    unless uncached_ids.empty?
-      uncached = CustomEmoji.where(shortcode: shortcodes, domain: domain, disabled: false).map { |item| [item.shortcode, item] }.to_h
+      uncached = CustomEmoji.where(shortcode: shortcodes, domain: domain, disabled: false).each_with_object({}) { |item, h| h[item.shortcode] = item }
      uncached.each_value { |item| Rails.cache.write(to_key(:emoji, item.shortcode, domain), item, expires_in: MAX_EXPIRATION) }
    end