Fix RSpec/SubjectStub cop (#25550)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
This commit is contained in:
Matt Jankowski
2023-07-12 04:02:19 -04:00
committed by GitHub
parent 7824df0eca
commit 74806deb2c
3 changed files with 9 additions and 11 deletions

View File

@ -11,14 +11,15 @@ RSpec.describe BlacklistedEmailValidator, type: :validator do
before do
allow(user).to receive(:valid_invitation?).and_return(false)
allow_any_instance_of(described_class).to receive(:blocked_email_provider?) { blocked_email }
allow(EmailDomainBlock).to receive(:block?) { blocked_email }
end
context 'when e-mail provider is blocked' do
let(:blocked_email) { true }
it 'adds error' do
expect(subject).to have_received(:add).with(:email, :blocked)
described_class.new.validate(user)
expect(errors).to have_received(:add).with(:email, :blocked).once
end
end
@ -26,7 +27,8 @@ RSpec.describe BlacklistedEmailValidator, type: :validator do
let(:blocked_email) { false }
it 'does not add errors' do
expect(subject).to_not have_received(:add).with(:email, :blocked)
described_class.new.validate(user)
expect(errors).to_not have_received(:add)
end
context 'when canonical e-mail is blocked' do
@ -37,7 +39,8 @@ RSpec.describe BlacklistedEmailValidator, type: :validator do
end
it 'adds error' do
expect(subject).to have_received(:add).with(:email, :taken)
described_class.new.validate(user)
expect(errors).to have_received(:add).with(:email, :taken).once
end
end
end