Migrate to request specs in /api/v1/bookmarks (#25520)
				
					
				
			This commit is contained in:
		@@ -1,80 +0,0 @@
 | 
			
		||||
# frozen_string_literal: true
 | 
			
		||||
 | 
			
		||||
require 'rails_helper'
 | 
			
		||||
 | 
			
		||||
RSpec.describe Api::V1::BookmarksController do
 | 
			
		||||
  render_views
 | 
			
		||||
 | 
			
		||||
  let(:user)  { Fabricate(:user) }
 | 
			
		||||
  let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:bookmarks') }
 | 
			
		||||
 | 
			
		||||
  describe 'GET #index' do
 | 
			
		||||
    context 'without token' do
 | 
			
		||||
      it 'returns http unauthorized' do
 | 
			
		||||
        get :index
 | 
			
		||||
        expect(response).to have_http_status 401
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    context 'with token' do
 | 
			
		||||
      context 'without read scope' do
 | 
			
		||||
        before do
 | 
			
		||||
          allow(controller).to receive(:doorkeeper_token) do
 | 
			
		||||
            Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: '')
 | 
			
		||||
          end
 | 
			
		||||
        end
 | 
			
		||||
 | 
			
		||||
        it 'returns http forbidden' do
 | 
			
		||||
          get :index
 | 
			
		||||
          expect(response).to have_http_status 403
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
 | 
			
		||||
      context 'without valid resource owner' do
 | 
			
		||||
        before do
 | 
			
		||||
          token = Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read')
 | 
			
		||||
          user.destroy!
 | 
			
		||||
 | 
			
		||||
          allow(controller).to receive(:doorkeeper_token) { token }
 | 
			
		||||
        end
 | 
			
		||||
 | 
			
		||||
        it 'returns http unprocessable entity' do
 | 
			
		||||
          get :index
 | 
			
		||||
          expect(response).to have_http_status 422
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
 | 
			
		||||
      context 'with read scope and valid resource owner' do
 | 
			
		||||
        before do
 | 
			
		||||
          allow(controller).to receive(:doorkeeper_token) do
 | 
			
		||||
            Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read')
 | 
			
		||||
          end
 | 
			
		||||
        end
 | 
			
		||||
 | 
			
		||||
        it 'shows bookmarks owned by the user' do
 | 
			
		||||
          bookmarked_by_user = Fabricate(:bookmark, account: user.account)
 | 
			
		||||
          bookmarked_by_others = Fabricate(:bookmark)
 | 
			
		||||
 | 
			
		||||
          get :index
 | 
			
		||||
 | 
			
		||||
          expect(assigns(:statuses)).to contain_exactly(bookmarked_by_user.status)
 | 
			
		||||
        end
 | 
			
		||||
 | 
			
		||||
        it 'adds pagination headers if necessary' do
 | 
			
		||||
          bookmark = Fabricate(:bookmark, account: user.account)
 | 
			
		||||
 | 
			
		||||
          get :index, params: { limit: 1 }
 | 
			
		||||
 | 
			
		||||
          expect(response.headers['Link'].find_link(%w(rel next)).href).to eq "http://test.host/api/v1/bookmarks?limit=1&max_id=#{bookmark.id}"
 | 
			
		||||
          expect(response.headers['Link'].find_link(%w(rel prev)).href).to eq "http://test.host/api/v1/bookmarks?limit=1&min_id=#{bookmark.id}"
 | 
			
		||||
        end
 | 
			
		||||
 | 
			
		||||
        it 'does not add pagination headers if not necessary' do
 | 
			
		||||
          get :index
 | 
			
		||||
 | 
			
		||||
          expect(response.headers['Link']).to be_nil
 | 
			
		||||
        end
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
end
 | 
			
		||||
		Reference in New Issue
	
	Block a user