Do not allow adding votes to expired polls (#10214)

* Do not allow adding votes to expired polls * Only validate expires_at on create
2019-03-08 00:54:50 +01:00
parent 054bbb3da2
commit 3aaac4f134
4 changed files with 26 additions and 1 deletions
--- a/app/services/vote_service.rb
+++ b/app/services/vote_service.rb
@ -11,6 +11,8 @@ class VoteService < BaseService
    @choices = choices
    @votes   = []

+    return if @poll.expired?
+
    ApplicationRecord.transaction do
      @choices.each do |choice|
        @votes << @poll.votes.create!(account: @account, choice: choice)