Fix Performance/CollectionLiteralInLoop cop (#24819)
This commit is contained in:
@ -5,6 +5,8 @@ class Admin::AppealFilter
|
||||
status
|
||||
).freeze
|
||||
|
||||
IGNORED_PARAMS = %w(page).freeze
|
||||
|
||||
attr_reader :params
|
||||
|
||||
def initialize(params)
|
||||
@ -15,7 +17,7 @@ class Admin::AppealFilter
|
||||
scope = Appeal.order(id: :desc)
|
||||
|
||||
params.each do |key, value|
|
||||
next if %w(page).include?(key.to_s)
|
||||
next if IGNORED_PARAMS.include?(key.to_s)
|
||||
|
||||
scope.merge!(scope_for(key, value.to_s.strip)) if value.present?
|
||||
end
|
||||
|
@ -6,6 +6,8 @@ class Admin::StatusFilter
|
||||
report_id
|
||||
).freeze
|
||||
|
||||
IGNORED_PARAMS = %w(page report_id).freeze
|
||||
|
||||
attr_reader :params
|
||||
|
||||
def initialize(account, params)
|
||||
@ -17,7 +19,7 @@ class Admin::StatusFilter
|
||||
scope = @account.statuses.where(visibility: [:public, :unlisted])
|
||||
|
||||
params.each do |key, value|
|
||||
next if %w(page report_id).include?(key.to_s)
|
||||
next if IGNORED_PARAMS.include?(key.to_s)
|
||||
|
||||
scope.merge!(scope_for(key, value.to_s.strip)) if value.present?
|
||||
end
|
||||
|
@ -169,6 +169,8 @@ class MediaAttachment < ApplicationRecord
|
||||
original: IMAGE_STYLES[:small].freeze,
|
||||
}.freeze
|
||||
|
||||
DEFAULT_STYLES = [:original].freeze
|
||||
|
||||
GLOBAL_CONVERT_OPTIONS = {
|
||||
all: '-quality 90 +profile "!icc,*" +set modify-date +set create-date',
|
||||
}.freeze
|
||||
|
@ -10,6 +10,8 @@ class RelationshipFilter
|
||||
location
|
||||
).freeze
|
||||
|
||||
IGNORED_PARAMS = %w(relationship page).freeze
|
||||
|
||||
attr_reader :params, :account
|
||||
|
||||
def initialize(account, params)
|
||||
@ -23,7 +25,7 @@ class RelationshipFilter
|
||||
scope = scope_for('relationship', params['relationship'].to_s.strip)
|
||||
|
||||
params.each do |key, value|
|
||||
next if %w(relationship page).include?(key)
|
||||
next if IGNORED_PARAMS.include?(key)
|
||||
|
||||
scope.merge!(scope_for(key.to_s, value.to_s.strip)) if value.present?
|
||||
end
|
||||
|
@ -6,6 +6,8 @@ class Trends::PreviewCardFilter
|
||||
locale
|
||||
).freeze
|
||||
|
||||
IGNORED_PARAMS = %w(page).freeze
|
||||
|
||||
attr_reader :params
|
||||
|
||||
def initialize(params)
|
||||
@ -16,7 +18,7 @@ class Trends::PreviewCardFilter
|
||||
scope = initial_scope
|
||||
|
||||
params.each do |key, value|
|
||||
next if %w(page).include?(key.to_s)
|
||||
next if IGNORED_PARAMS.include?(key.to_s)
|
||||
|
||||
scope.merge!(scope_for(key, value.to_s.strip)) if value.present?
|
||||
end
|
||||
|
@ -6,6 +6,8 @@ class Trends::StatusFilter
|
||||
locale
|
||||
).freeze
|
||||
|
||||
IGNORED_PARAMS = %w(page).freeze
|
||||
|
||||
attr_reader :params
|
||||
|
||||
def initialize(params)
|
||||
@ -16,7 +18,7 @@ class Trends::StatusFilter
|
||||
scope = initial_scope
|
||||
|
||||
params.each do |key, value|
|
||||
next if %w(page).include?(key.to_s)
|
||||
next if IGNORED_PARAMS.include?(key.to_s)
|
||||
|
||||
scope.merge!(scope_for(key, value.to_s.strip)) if value.present?
|
||||
end
|
||||
|
Reference in New Issue
Block a user